Skip to content

Create Reflow Tests#2429

Draft
HelenBurge wants to merge 7 commits into
developfrom
Reflow-tests
Draft

Create Reflow Tests#2429
HelenBurge wants to merge 7 commits into
developfrom
Reflow-tests

Conversation

@HelenBurge

Copy link
Copy Markdown
Collaborator

First draft of the content reflow test

Creating the first draft of a reflow test, one of three new rules

Closes issue(s):

Need for Call for Review:
This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

First draft of the content reflow test
@netlify

netlify Bot commented Jul 13, 2026

Copy link
Copy Markdown

Deploy Preview for act-rules failed.

Name Link
🔨 Latest commit 8de47f2
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a54ef00cd05980008f5ed36

@HelenBurge HelenBurge self-assigned this Jul 13, 2026
@HelenBurge
HelenBurge requested a review from G0dwin July 13, 2026 11:18
@HelenBurge HelenBurge added the Rule Use this label for a new rule that does not exist already label Jul 13, 2026
@HelenBurge
HelenBurge marked this pull request as draft July 13, 2026 13:31
@HelenBurge HelenBurge changed the title Create content-present-reflow-sc9kkf Create Reflow Tests Jul 13, 2026
@HelenBurge

Copy link
Copy Markdown
Collaborator Author

I know I have to add references and definitions to the tests - TBD

@WilcoFiers
WilcoFiers requested a review from giacomo-petri July 23, 2026 14:19

#### Failed Example 2

Navigation items removed instead of adapted.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a repetition of the first example. Does this add or clarify something that the first example doesn't cover?


#### Failed Example 4

Content moved off-screen and not reachable.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like this content would not be available at any viewport size, this is also a common valid technique for applying text only available to AT.

Each target element:
Retains all content and functionality when viewed at 320 CSS pixels; and
- Does not hide, remove, or make content unavailable as a result of viewport constraints, zoom, or responsive behaviour; and
- Ensures that any content that is visually hidden at this viewport size is still programmatically available and accessible to users.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the examples that you included that always hide content, I feel like we may need to define a way to compare before and after. For example, should we compare content at 1280 vs 320?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rule Use this label for a new rule that does not exist already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reflow tests to be written

2 participants