Create Reflow Tests#2429
Draft
HelenBurge wants to merge 7 commits into
Draft
Conversation
First draft of the content reflow test
❌ Deploy Preview for act-rules failed.
|
HelenBurge
marked this pull request as draft
July 13, 2026 13:31
Collaborator
Author
|
I know I have to add references and definitions to the tests - TBD |
G0dwin
reviewed
Jul 25, 2026
|
|
||
| #### Failed Example 2 | ||
|
|
||
| Navigation items removed instead of adapted. |
Collaborator
There was a problem hiding this comment.
This looks like a repetition of the first example. Does this add or clarify something that the first example doesn't cover?
G0dwin
reviewed
Jul 25, 2026
|
|
||
| #### Failed Example 4 | ||
|
|
||
| Content moved off-screen and not reachable. |
Collaborator
There was a problem hiding this comment.
It looks to me like this content would not be available at any viewport size, this is also a common valid technique for applying text only available to AT.
G0dwin
reviewed
Jul 25, 2026
| Each target element: | ||
| Retains all content and functionality when viewed at 320 CSS pixels; and | ||
| - Does not hide, remove, or make content unavailable as a result of viewport constraints, zoom, or responsive behaviour; and | ||
| - Ensures that any content that is visually hidden at this viewport size is still programmatically available and accessible to users. |
Collaborator
There was a problem hiding this comment.
With the examples that you included that always hide content, I feel like we may need to define a way to compare before and after. For example, should we compare content at 1280 vs 320?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of the content reflow test
Creating the first draft of a reflow test, one of three new rules
Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve