Skip to content

Point to the WCAG 2.2 definition of image of text#2433

Merged
daniel-montalvo merged 1 commit into
act-rules:developfrom
remibetin:rule-2ee8b8-image-of-text
Jul 24, 2026
Merged

Point to the WCAG 2.2 definition of image of text#2433
daniel-montalvo merged 1 commit into
act-rules:developfrom
remibetin:rule-2ee8b8-image-of-text

Conversation

@remibetin

@remibetin remibetin commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

The current sentence essentially points to SC 2.5.3 Label in Name twice: in /TR and in Understanding.

That might not be intentional for "image of text". I'm suggesting pointing to the "image of text" glossary entry in WCAG 2.2, but it would be important to double-check with authors if this was indeed the intent.

This was raised as part of the review of w3c/wcag-act-rules#431.

Need for Call for Review: Unclear to me.

<< choose one of the following and remove the rest >>
<< check Process Document on Call for Review >>
This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain). >>
This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >>
This will require a 1 week Call for Review << small changes affecting a small number of examples, if in doubt do not use this. >>
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of examples, if in doubt, use this. >>


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • [ ] If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@remibetin remibetin self-assigned this Jul 24, 2026
@remibetin remibetin added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label Jul 24, 2026
@netlify

netlify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 61f00c9
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a633e1b1e3ff800082ba99b
😎 Deploy Preview https://deploy-preview-2433--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@daniel-montalvo

Copy link
Copy Markdown
Collaborator

@WilcoFiers @dan-tripp-siteimprove

I think this is editorial and can be merged with just two approvals.

@daniel-montalvo daniel-montalvo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, this clarifies the meaning of the paragraph.

@daniel-montalvo
daniel-montalvo merged commit aac0e99 into act-rules:develop Jul 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Editorial For editorial changes that does not change the meaning of a rule or Glossary term

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants