Skip to content

Minor editorial changes#2434

Merged
daniel-montalvo merged 3 commits into
act-rules:developfrom
remibetin:rule-2ee8b8-fixes
Jul 24, 2026
Merged

Minor editorial changes#2434
daniel-montalvo merged 3 commits into
act-rules:developfrom
remibetin:rule-2ee8b8-fixes

Conversation

@remibetin

Copy link
Copy Markdown
Collaborator

This PR updates "button" to "link" in Failed Example 3 and adds a missing space to Failed Example 4.

This was raised as part of the review of w3c/wcag-act-rules#431.

Need for Call for Review:

This can be merged with 1 approval: editorial changes


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • [ ] If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@remibetin remibetin self-assigned this Jul 24, 2026
@remibetin remibetin added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label Jul 24, 2026
@netlify

netlify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 297bb34
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a635bf5bef9c80008751176
😎 Deploy Preview https://deploy-preview-2434--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread _rules/visible-label-in-accessible-name-2ee8b8.md Outdated
Comment thread _rules/visible-label-in-accessible-name-2ee8b8.md Outdated
@daniel-montalvo

Copy link
Copy Markdown
Collaborator

Thanks much @remibetin for taking the time to bring these suggestions back to the source repo.

See a couple of minor suggestions aligned with work on #2428

@remibetin

Copy link
Copy Markdown
Collaborator Author

See a couple of minor suggestions aligned with work on #2428

Thanks much for the suggestions, @daniel-montalvo.

I'm hesitant to include these suggestions in this PR. These two instances of "So it fails the rule." should be properly removed once #2428 is merged.

@remibetin

Copy link
Copy Markdown
Collaborator Author

I'm hesitant to include these suggestions in this PR. These two instances of "So it fails the rule." should be properly removed once #2428 is merged.

I overlooked that, by affecting the same lines, #2428 would conflict with the current PR. I've just fixed the conflicts.

@daniel-montalvo daniel-montalvo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Ready to merge as editorial PRs require just one review according to PR template.

@daniel-montalvo
daniel-montalvo merged commit cc63149 into act-rules:develop Jul 24, 2026
6 checks passed
@remibetin
remibetin deleted the rule-2ee8b8-fixes branch July 24, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Editorial For editorial changes that does not change the meaning of a rule or Glossary term

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants