Add context: . to the docker/build-push-action#4501
Open
Okabe-Junya wants to merge 1 commit into
Open
Conversation
Okabe-Junya
requested review from
Steve-Glass,
nikola-jokic,
rentziass and
toast-gear
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR makes the Docker build steps in the GitHub Actions workflows explicitly use the repository root as the build context.
Changes:
- Add
context: .to the Docker build step in the chart validation workflow. - Add
context: .to the Docker build & push step in the chart publish workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/gha-validate-chart.yaml | Explicitly sets Docker build context to repo root for validation builds. |
| .github/workflows/gha-publish-chart.yaml | Explicitly sets Docker build context to repo root for publish builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. mercari#24
What
Add
context: .to thedocker/build-push-actionstep ingha-publish-chart.yamlandgha-validate-chart.yaml.Why
Without
context, the action falls back to the Git context and re-clones the repo inside BuildKit, ignoring the workspace fromactions/checkout(including any pre-build file mutations and.dockerignoreprocessing). Settingcontext: .makes the checked-out workspace the source of truth and avoids the redundant clone.