You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why: The suggestion increases robustness by adding a boundary check for w.WorkflowRecord.WorkflowSteps to avoid potential panic. It addresses a potential runtime error, although it is a safety improvement rather than a critical bug fix.
Why: The code change refactors the index calculation for clarity by explicitly handling the zero case, making the logic more readable. However, its functional impact is minor as it achieves similar behavior to the original logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/sqle-ee/issues/2682
link https://github.com/actiontech/sqle-ee/pull/2688
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
修改导出流程展示逻辑:驳回状态不显示当前步骤处理人
更新SQL查询:驳回时将当前步骤指派用户改为创建者
优化数据库字符串扫描错误处理,增加nil及类型判断
Diagram Walkthrough
File Walkthrough
data_export_workflow.go
更新服务层步骤指派逻辑internal/dms/service/data_export_workflow.go
workflow.go
改进SQL查询及当前步骤数据处理internal/dms/storage/workflow.go
model.go
优化数据库字符串扫描处理internal/dms/storage/model/model.go