Repository navigation
Report why a streamed generation stopped - #610
Closed
pcbeingused333 wants to merge 2 commits into
Closed
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
A streamed generation has no response body, so response.finish_reason (and its stop_reason alias) was always nil for streamed Chat and Anthropic generations, and so was the finish_reason of the prompt.active_agent instrumentation event. Record it from the stream (the chunk's finish_reason for Chat, the message_delta's stop_reason for Anthropic) and let the response fall back to it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
Contributor
|
Closing as superseded: #613 carries this change (the streamed Generated by Claude Code |
yorzi
pushed a commit
to yorzi/activeagent
that referenced
this pull request
Oct 22, 2026
…eneration stopped Carries activeagents#610 (a streamed generation reports why it stopped). Resolved on main: the changelog bullets join the Fixed section under Unreleased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response.finish_reason(and itsstop_reasonalias) reads the provider's response body:choices[0].finish_reasonfor OpenAI Chat,stop_reasonfor Anthropic. A streamed generation has no response body (process_prompt_finishedruns without one), sofinish_reasonwasnilfor every streamed Chat and Anthropic generation, and so was thefinish_reasonof theprompt.active_agentinstrumentation event and thefinish=part of the log line. A caller can't tell a complete answer from one cut off atmax_tokens(length) or a tool call turn.This change records it from the stream: the Chat provider takes the chunk's
finish_reason, the Anthropic provider themessage_delta'sstop_reason. The provider hands it to the response asstreamed_finish_reason, andfinish_reasonfalls back to it when there is noraw_response. Non-streamed responses read the body as before. With tool calling the response reports the last turn's reason.Tests:
test/providers/open_ai/chat/streaming_finish_reason_test.rbandtest/providers/anthropic/streaming_finish_reason_test.rb: a streamed generation over the real wire format (WebMock SSE) reportsstop/length(Chat) andend_turn/max_tokens(Anthropic). Both fail onmainwithnil.test/providers/**andtest/integration/**(openai/anthropic gems, rails8 gemfile, dummy API keys for VCR): 1340 runs, 0 failures. The 6 errors (RubyLLMIntegrationTest,SolidAgentCompatibilityTest) happen onmaintoo and don't involve this code. Rubocop is clean, and there's a CHANGELOG entry.Not in this change: the OpenAI Responses provider streams too, but reports its stop reason in
status/incomplete_details, a different vocabulary; it still returnsniland is left for a follow-up.This change was made with Claude Code; the tests above were run on the branch.
🤖 Generated with Claude Code