Add I2C sensor settings for backported v2 drivers#335
Closed
tyeth-ai-assisted wants to merge 1 commit into
Closed
Conversation
Adds index-based `settings` blocks (per the v2 settings schema, ref adafruit#327) to the I2C components whose firmware drivers were backported with configurable options in Adafruit_Wippersnapper_Arduino. Each setting's option order and default index matches the firmware driver's set* mapping / configureDefaults(). Components updated: ina260, ina237, ina238, ina228, lps28dfw, spa06_003, htu31d, hdc302x, as7331, as5600, mlx90632b, mlx90632d_med, mlx90632d_ext, vcnl4200, vcnl4030. Notes: - The settings model is index-into-options only, so continuous/physical calibration values (INA shunt resistance & max current; AS5600 zero/max angle positions) are intentionally not surfaced here. - SPA06-003 exposes the 1-128 Hz output-data-rate subset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
Superseded by #336, which also carries the schema change (a staff-only file) and so is opened from the tyeth fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds index-based
settingsblocks to the I2C components whose firmware drivers were backported with configurable options in Adafruit_Wippersnapper_Arduino#933. This is the components-side counterpart to that firmware work, in the same spirit as #327.Each setting's option order and default index matches the firmware driver's
set*index mapping /configureDefaults(), so the broker-sent index resolves to the intended sensor configuration.Components updated (15)
Notes / scope
schema.json). Continuous/physical calibration values are therefore intentionally not surfaced: INA shunt resistance & max-current (setShunt, fixed on the Adafruit breakouts) and AS5600 zero/max angle positions. The firmware retains those as defaults.output_data_ratesubset (the library's higher background-rate combos are omitted).components/i2c/schema.json.🤖 Generated with Claude Code