ci: diff changed files against the PR target branch#339
Closed
tyeth-ai-assisted wants to merge 1 commit into
Closed
ci: diff changed files against the PR target branch#339tyeth-ai-assisted wants to merge 1 commit into
tyeth-ai-assisted wants to merge 1 commit into
Conversation
The "List All Changed Files" step always diffed against origin/main, so PRs targeting v2 swept every v2-vs-main difference (.gitignore, etc.) into the filename validation and flagged them spuriously. Diff against v2 when the PR targets v2; otherwise diff against main (unchanged for main and workflow_dispatch). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Superseded by a PR from the adafruit repo branch directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #337 (commit 319af49) so the CI fix can land on
mainseparately.The "List All Changed Files" step in
validate.ymlalways diffed againstorigin/main, so PRs targetingv2swept every v2-vs-main difference (.gitignore, etc.) into the filename validation and flagged them spuriously.This changes the step to diff against the PR's actual target branch:
v2when the PR targetsv2, otherwisemain(behavior unchanged for PRs againstmainand forworkflow_dispatch).🤖 Generated with Claude Code