feat: exponer /metrics del OWC para scraping (PodMonitor)#82
Open
az-adhoc wants to merge 1 commit into
Open
Conversation
Agrega el puerto de métricas (9081) al Deployment del adhoc-wakeup-controller y un PodMonitor opcional para que Prometheus scrapee el endpoint /metrics que expone la nueva instrumentación del controller. - deployment: containerPort `metrics` (9081) + env METRICS_PORT. - values: metricsPort + bloque metrics.podMonitor (enabled/interval/additionalLabels). - templates/podmonitor.yaml: PodMonitor gated por metrics.podMonitor.enabled. podMonitor.enabled=false por default: requiere una imagen del OWC que sirva /metrics (feat/owc-metrics en adelante) y el CRD PodMonitor del operator. Se habilita explícito para el canary y al promover la imagen con métricas a stable. Los cambios al Deployment son inocuos con la imagen actual (nada escucha en 9081 todavía). Instrumentación: ingadhoc/devops-ops-tools#24 Spec: ingadhoc/devops-project specs/10_draft/wakeup-controller-metrics.md (#69684)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Expone el endpoint
/metricsdel adhoc-wakeup-controller para que Prometheus lo scrapee. Es la pieza de chart (Fase 6) que acompaña a la instrumentación del controller en ingadhoc/devops-ops-tools#24, según la specwakeup-controller-metrics.md(tarea #69684).Cambios (
charts/adhoc-wakeup-controller)metrics(9081) + envMETRICS_PORT.metricsPort: 9081+ bloquemetrics.podMonitor(enabled/interval/additionalLabels).PodMonitorgated pormetrics.podMonitor.enabled.0.3.2→0.4.0.Seguridad del default
podMonitor.enabled=falsepor default a propósito:/metrics(feat/owc-metricsen adelante) y el CRDPodMonitordel prometheus-operator.--set metrics.podMonitor.enabled=true) y, cuando la imagen con métricas se promueva a stable, se flipea el default + se bumpeaappVersion.Test plan
helm lint: OKhelm templatedefault → 0 PodMonitor (gated off); Deployment con containerPort 9081 +METRICS_PORT.helm template --set metrics.podMonitor.enabled=true→ PodMonitor renderiza conadditionalLabels, selector correcto,port: metrics,path: /metrics.Siguiente
Habilita el canary para validar las métricas end-to-end (build de imagen
feat/owc-metrics→helm installdel controller canary con dominio aislado +podMonitor.enabled=true).