Skip to content

chore: batch Renovate dependency updates#274

Closed
sirugh wants to merge 3 commits into
mainfrom
renovate-all
Closed

chore: batch Renovate dependency updates#274
sirugh wants to merge 3 commits into
mainfrom
renovate-all

Conversation

@sirugh
Copy link
Copy Markdown
Collaborator

@sirugh sirugh commented May 5, 2026

Summary

Combines 14 open Renovate bot PRs into a single update to avoid triggering multiple stage deploys. All tests pass (123/123).

Closes Renovate PRs: #204, #210, #213, #218, #221, #222, #225, #230, #233, #240, #251, #252, #260, #269

Security CVEs resolved

Package CVE Change
js-yaml CVE-2025-64718 (prototype pollution) 4.1.0 to 4.1.1
vega CVE-2025-59840 (XSS via expressions) 6.1.2 to 6.2.0
diff CVE-2026-24001 (DoS in parsePatch) 8.0.2 to 8.0.4
handlebars CVE-2026-33916 (prototype pollution XSS) 4.7.8 to 4.7.9

npm audit now reports only 3 high severity findings (down from 33 including 3 critical), all in tar-fs via @openwhisk/wskdebug (dev-only debug tool).

Other notable updates

  • p-limit ^6.2.0 to ^7.0.0 (v7 is ESM-only; code already uses dynamic import pattern)
  • msw 2.10.5 to 2.14.3
  • jest 30.0.5 to 30.3.0, eslint 9.33.0 to 9.39.4
  • dotenv 17.2.1 to 17.4.2
  • @adobe/aio-lib-runtime 7.1.4 to 7.3.0
  • aio-apps-action v3 to v4 in all GitHub Actions workflows

Test changes (required for msw 2.14.x compatibility)

msw 2.14.x introduced ESM-only transitive dependencies (rettime, @open-draft/deferred-promise) that break CJS require('msw/node'). The four affected test files were converted from .js (CJS) to .mjs (ESM):

  • test/mock-server.js to test/mock-server.mjs
  • test/utils.test.js to test/utils.test.mjs
  • test/ldJson.test.js to test/ldJson.test.mjs
  • test/pdp-renderer.test.js to test/pdp-renderer.test.mjs

Key changes: import { jest } from '@jest/globals' (jest global not auto-injected in .mjs), jest.mock() instead of jest.unstable_mockModule() to intercept CJS require('@adobe/aio-sdk'), import * as cheerio (no default export in ESM).

After merge

Please close the individual Renovate PRs: gh pr close 204 210 213 218 221 222 225 230 233 240 251 252 260 269

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

sirugh and others added 3 commits May 5, 2026 14:40
Combines 14 open Renovate bot PRs (#204, #210, #213, #218, #221, #222,
#225, #230, #233, #240, #251, #252, #260, #269) into a single update.

Security fixes (all CVEs resolved):
- js-yaml 4.1.0 → 4.1.1 (CVE-2025-64718 prototype pollution)
- vega 6.1.2 → 6.2.0 (CVE-2025-59840 XSS via expressions)
- diff 8.0.2 → 8.0.4 (CVE-2026-24001 DoS in parsePatch)
- handlebars 4.7.8 → 4.7.9 (CVE-2026-33916 prototype pollution XSS)

Other updates via npm update:
- p-limit ^6.2.0 → ^7.0.0 (ESM-only; project already uses dynamic import)
- msw 2.10.5 → 2.14.3
- jest 30.0.5 → 30.3.0, eslint 9.33.0 → 9.39.4
- dotenv 17.2.1 → 17.4.2, globals 16.3.0 → 16.5.0
- @adobe/aio-lib-runtime 7.1.4 → 7.3.0
- aio-apps-action v3 → v4 in all GitHub Actions workflows (PR #222)

Test fix: msw 2.14.x pulls in ESM-only transitive deps (rettime,
@open-draft/deferred-promise) that break CJS require(). Converted
test/mock-server, utils.test, ldJson.test, and pdp-renderer.test to
.mjs (ESM). Uses jest.mock() (not jest.unstable_mockModule) to intercept
CJS require('@adobe/aio-sdk') in the action under test. Adds
import { jest } from '@jest/globals' since jest global is not
auto-injected in ESM modules.

Remaining unfixable vulnerabilities (require upstream @adobe/aio-sdk fix):
- None after this update — resolved by @adobe/aio-lib-runtime 7.3.0

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add ESLint flat config blocks for *.mjs files (sourceType: module,
  node globals) and *.test.mjs / test/mock-server.mjs (jest plugin +
  globals), matching the existing *.test.js pattern
- Fix rettime.cjs empty catch: `catch (_) {}` → `catch { /* ignore */ }`
  to resolve no-unused-vars and no-empty ESLint errors

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Delete test/__mocks__/rettime.cjs — never loaded (wrong directory for
  auto-mocking, no moduleNameMapper, msw CJS doesn't require rettime directly)
- Fix Apache 2.0 header in utils.test.mjs: 'LICENSE' → 'License'

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sirugh sirugh closed this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant