Skip to content

feat(executive-summary): add executive summary tab with WoW metrics, callouts, and data pipeline#48

Open
subodh2711 wants to merge 4 commits into
devfrom
feature/executive-summary-tab
Open

feat(executive-summary): add executive summary tab with WoW metrics, callouts, and data pipeline#48
subodh2711 wants to merge 4 commits into
devfrom
feature/executive-summary-tab

Conversation

@subodh2711
Copy link
Copy Markdown
Collaborator

@subodh2711 subodh2711 commented May 18, 2026

URL for testing:

Introduces a fully self-contained Executive Summary tab backed by a static JSON file extracted from HDFC weekly/monthly HTML reports.

Key additions:

  • dashboards/executive-dashboard.js — shadow-DOM web component rendering hero, KPI strip (V1/EDS), callout signals (Wins/Watch/Action Needed), Week-over-Week 4-card section, weekly trends table, and monthly summary
  • scripts/extract-hdfc-data.js — Node.js pipeline that parses HDFC report HTML into data/hdfc-executive.json (auto-discovers weekly wNN folders and monthly folders; no hardcoded lists)
  • scripts/watch-reports.js — fs.watch wrapper that re-runs extraction automatically when report HTML files change
  • package.json — adds "extract" and "watch:reports" npm scripts

Notable fixes in this branch:

  • Banner summary extraction: switched from nested- regex terminator to start-position + 800-char window so banner.summary is never null
  • Page Views delta colour: ▲ (more traffic) now correctly renders green
  • Missing Resources KPI card: WoW delta added (was showing no trend)
  • Callout order: signals panel moved above WoW cards for executive scan
  • "Strong Signals" renamed to "Wins This Week" for executive clarity
  • err-sig developer chips removed from callout items
  • Dead code removed: wowBadge(), errorType(), errSigHtml(), .wow-row CSS, empty CSS rules, divide-x invalid property, duplicate @import font load
  • Shadow re-attach guard added (connectedCallback idempotent)

Tests:

  • tests/unit/executive-dashboard.test.js (39 tests)
  • tests/unit/extract-hdfc-data.test.js (30 tests) All 121 unit tests pass.

Description

PR Review Checklist

  • Change is described and scoped (issue link or short description above).
  • Tests/checks: Unit and/or E2E tests were run (or N/A with reason).
  • Lint passes (npm run lint); no new violations introduced.
  • Documentation / agent context (e.g. CLAUDE.md, .specify/) updated if this change affects them (or N/A).
  • If implementing a spec: spec/plan were followed and tasks.md (or equivalent) reflected (or N/A).

Preview URLs

Before (baseline): https://dev--forms-dashboard--adobe-rnd.aem.live/index.html
After (this branch): https://feature-executive-summary-tab--forms-dashboard--adobe-rnd.aem.live/index.html

…callouts, and data pipeline

Introduces a fully self-contained Executive Summary tab backed by a
static JSON file extracted from HDFC weekly/monthly HTML reports.

Key additions:
- dashboards/executive-dashboard.js — shadow-DOM web component rendering
  hero, KPI strip (V1/EDS), callout signals (Wins/Watch/Action Needed),
  Week-over-Week 4-card section, weekly trends table, and monthly summary
- scripts/extract-hdfc-data.js — Node.js pipeline that parses HDFC report
  HTML into data/hdfc-executive.json (auto-discovers weekly wNN folders
  and monthly folders; no hardcoded lists)
- scripts/watch-reports.js — fs.watch wrapper that re-runs extraction
  automatically when report HTML files change
- package.json — adds "extract" and "watch:reports" npm scripts

Notable fixes in this branch:
- Banner summary extraction: switched from nested-</div> regex terminator
  to start-position + 800-char window so banner.summary is never null
- Page Views delta colour: ▲ (more traffic) now correctly renders green
- Missing Resources KPI card: WoW delta added (was showing no trend)
- Callout order: signals panel moved above WoW cards for executive scan
- "Strong Signals" renamed to "Wins This Week" for executive clarity
- err-sig developer chips removed from callout items
- Dead code removed: wowBadge(), errorType(), errSigHtml(), .wow-row CSS,
  empty CSS rules, divide-x invalid property, duplicate @import font load
- Shadow re-attach guard added (connectedCallback idempotent)

Tests:
- tests/unit/executive-dashboard.test.js (39 tests)
- tests/unit/extract-hdfc-data.test.js (30 tests)
All 121 unit tests pass.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 18, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 18, 2026

Page Scores Audits Google
📱 /index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /index.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an Executive Dashboard feature, consisting of a new web component for data visualization, a script to extract structured data from HDFC RUM reports, and a watcher for automated data updates. The dashboard includes sections for KPIs, week-over-week trends, and automated callouts for performance signals. Reviewers suggested optimizing the dashboard's mounting logic to prevent redundant re-renders, refining the deltaSpan utility to support neutral styling for zero-percent changes, and improving the data extraction script's portability and robustness by avoiding hardcoded paths and fixed-length string parsing.

Comment thread app.js Outdated
Comment thread dashboards/executive-dashboard.js
Comment thread scripts/extract-hdfc-data.js Outdated
Comment thread scripts/extract-hdfc-data.js Outdated
Comment thread scripts/extract-hdfc-data.js Outdated
…vars)

Replace == null with strict === null || === undefined checks, rename unused
`prev` parameter to `_prev` in computeCallouts.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@aem-code-sync aem-code-sync Bot temporarily deployed to feature/executive-summary-tab May 18, 2026 17:14 Inactive
- app.js: skip re-mounting executive-dashboard if already present to avoid
  redundant re-renders and duplicate data fetches
- executive-dashboard.js: deltaSpan now returns neutral badge for <0.05% change
  instead of incorrectly classifying as good/bad
- extract-hdfc-data.js: make REPORTS_BASE configurable via REPORTS_BASE env var
  or first CLI arg; remove hardcoded 8-row limit on journey rows; replace
  fixed 800-char banner window with proper div-depth tracking (sliceToMatchingClose)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@aem-code-sync aem-code-sync Bot temporarily deployed to feature/executive-summary-tab May 18, 2026 17:16 Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants