feat(executive-summary): add executive summary tab with WoW metrics, callouts, and data pipeline#48
Open
subodh2711 wants to merge 4 commits into
Open
feat(executive-summary): add executive summary tab with WoW metrics, callouts, and data pipeline#48subodh2711 wants to merge 4 commits into
subodh2711 wants to merge 4 commits into
Conversation
…callouts, and data pipeline Introduces a fully self-contained Executive Summary tab backed by a static JSON file extracted from HDFC weekly/monthly HTML reports. Key additions: - dashboards/executive-dashboard.js — shadow-DOM web component rendering hero, KPI strip (V1/EDS), callout signals (Wins/Watch/Action Needed), Week-over-Week 4-card section, weekly trends table, and monthly summary - scripts/extract-hdfc-data.js — Node.js pipeline that parses HDFC report HTML into data/hdfc-executive.json (auto-discovers weekly wNN folders and monthly folders; no hardcoded lists) - scripts/watch-reports.js — fs.watch wrapper that re-runs extraction automatically when report HTML files change - package.json — adds "extract" and "watch:reports" npm scripts Notable fixes in this branch: - Banner summary extraction: switched from nested-</div> regex terminator to start-position + 800-char window so banner.summary is never null - Page Views delta colour: ▲ (more traffic) now correctly renders green - Missing Resources KPI card: WoW delta added (was showing no trend) - Callout order: signals panel moved above WoW cards for executive scan - "Strong Signals" renamed to "Wins This Week" for executive clarity - err-sig developer chips removed from callout items - Dead code removed: wowBadge(), errorType(), errSigHtml(), .wow-row CSS, empty CSS rules, divide-x invalid property, duplicate @import font load - Shadow re-attach guard added (connectedCallback idempotent) Tests: - tests/unit/executive-dashboard.test.js (39 tests) - tests/unit/extract-hdfc-data.test.js (30 tests) All 121 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
There was a problem hiding this comment.
Code Review
This pull request introduces an Executive Dashboard feature, consisting of a new web component for data visualization, a script to extract structured data from HDFC RUM reports, and a watcher for automated data updates. The dashboard includes sections for KPIs, week-over-week trends, and automated callouts for performance signals. Reviewers suggested optimizing the dashboard's mounting logic to prevent redundant re-renders, refining the deltaSpan utility to support neutral styling for zero-percent changes, and improving the data extraction script's portability and robustness by avoiding hardcoded paths and fixed-length string parsing.
…vars) Replace == null with strict === null || === undefined checks, rename unused `prev` parameter to `_prev` in computeCallouts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- app.js: skip re-mounting executive-dashboard if already present to avoid redundant re-renders and duplicate data fetches - executive-dashboard.js: deltaSpan now returns neutral badge for <0.05% change instead of incorrectly classifying as good/bad - extract-hdfc-data.js: make REPORTS_BASE configurable via REPORTS_BASE env var or first CLI arg; remove hardcoded 8-row limit on journey rows; replace fixed 800-char banner window with proper div-depth tracking (sliceToMatchingClose) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL for testing:
Introduces a fully self-contained Executive Summary tab backed by a static JSON file extracted from HDFC weekly/monthly HTML reports.
Key additions:
Notable fixes in this branch:
Tests:
Description
PR Review Checklist
npm run lint); no new violations introduced.Preview URLs
Before (baseline): https://dev--forms-dashboard--adobe-rnd.aem.live/index.html
After (this branch): https://feature-executive-summary-tab--forms-dashboard--adobe-rnd.aem.live/index.html