Maintenance for 5.1.0 ctd#3084
Merged
Merged
Conversation
AWS SDK v2 for Java has changed its dependency management, no Apache HTTPClient
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues 5.1.0 maintenance by updating AWS SDK dependency versions in the parent build, ensuring integration tests include the AWS SDK v2 Apache HTTP client, and updating the 5.1.0 planned changelog entries accordingly.
Changes:
- Bump AWS SDK versions in the root Maven properties (
aws.sdk.kotlinand AWS SDK v2). - Add
software.amazon.awssdk:apache-clientas a test dependency for the integration-tests module. - Update the
CHANGELOG.md5.1.0 (planned) dependency-bump notes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pom.xml | Updates AWS SDK Kotlin and AWS SDK v2 version properties. |
| integration-tests/pom.xml | Adds AWS SDK v2 apache-client test dependency for integration tests. |
| CHANGELOG.md | Updates planned 5.1.0 entries for dependency/version bumps (contains a few inconsistencies vs current build pins). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
165
to
167
| * Bump com.github.gantsign.maven:ktlint-maven-plugin from 3.7.0 to 3.7.1 | ||
| * Bump com.puppycrawl.tools:checkstyle from 13.4.0 to 13.5.0 | ||
| * Bump com.puppycrawl.tools:checkstyle from 13.4.0 to 13.6.0 | ||
| * Bump digital.pragmatech.testing:spring-test-profiler from 0.1.0 to 0.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: