fix: ignore blank initialBuckets entries during startup#3085
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a startup edge case where initialBuckets containing blank entries (e.g., [""]) could trigger creation of an invalid persisted bucket at the storage root, leading to bad state after restart.
Changes:
- Filter out blank/whitespace-only
initialBucketsentries during bucket store initialization. - Add a regression test asserting that blank
initialBucketsdoes not create buckets or write files to the root store directory. - Document the fix in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
server/src/main/kotlin/com/adobe/testing/s3mock/store/StoreConfiguration.kt |
Filters blank initialBuckets entries before attempting bucket creation. |
server/src/test/kotlin/com/adobe/testing/s3mock/store/StoreConfigurationTest.kt |
Adds regression test for initialBuckets = listOf(\"\"). |
CHANGELOG.md |
Notes the bug fix in the planned release section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c35b724 to
1fc8c6f
Compare
5 tasks
1fc8c6f to
4a47101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rebased branch from #3071 onto main.
Related Issue
N/A
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: