FORMS-25355: Make checkedValue required in Checkbox dialog#1876
Open
vdua wants to merge 2 commits into
Open
Conversation
Mark checkedValue as a required field in the checkbox component dialog to prevent silent fallback to the HTML default "on" when authors omit a value. The _cq_template.xml already provides "on"/"off" as defaults for new instances. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: vdua <vdua@adobe.com>
- Set value="on" on the checkedValue dialog field so existing/programmatically created checkboxes without a stored JCR property see "on" as the default - Add Cypress authoring tests verifying checkedValue is pre-filled with "on" and that the required validation blocks dialog submit when the field is empty Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: vdua <vdua@adobe.com>
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark checkedValue as a required field in the checkbox component dialog to prevent silent fallback to the HTML default "on" when authors omit a value. The _cq_template.xml already provides "on"/"off" as defaults for new instances.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: