Skip to content

feat: Add secondary reference line#824

Open
tanugarg04 wants to merge 5 commits into
mainfrom
AN-450459
Open

feat: Add secondary reference line#824
tanugarg04 wants to merge 5 commits into
mainfrom
AN-450459

Conversation

@tanugarg04

@tanugarg04 tanugarg04 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

Adds secondary?: boolean to the S2 component (AN-450459). Secondary lines are a lighter-emphasis variant intended for contextual values (averages, baselines) that should visually recede behind a primary target line.

Visual differences vs. primary:

  • No caret caps (start and end triangles omitted)
  • Rule spans full chart width (no cap-clearance offsets on either side)
  • Stroke color is size-dependent: gray-600 at XS, gray-800 for S/M/L and auto mode
  • Label rendered in gray-600 for all sizes

Stroke weight is unchanged — same size table as primary (XS=1px, S=1.5px, M=1.5px, L=2.5px).

LineReferenceLine.story.tsx — adds SecondaryBasic, WithSecondary, and PrimaryAndSecondary stories

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread packages/docs/docs/spectrum2/line.md Outdated
tanugarg04 and others added 3 commits June 16, 2026 12:02
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… stroke color

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants