feat: Hide and show with new legend icon#826
Open
tanugarg04 wants to merge 2 commits into
Open
Conversation
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-826 🎨 S2 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-826-s2 📚 Docs -> https://opensource.adobe.com/react-spectrum-charts/PR-826-docs/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AN-450448 — S2 Legend: VisibilityOff icon overlay for hidden series
Description
In S1, clicking a toggleable legend entry grays the swatch and label to gray-300/gray-500. In S2 the design is different: the swatch visually disappears (background color via Vega signal), the label stays at full opacity, and a VisibilityOff icon from @spectrum-icons/workflow overlays the swatch position. Clicking again removes the icon and restores the swatch.
The series hide/show toggle mechanics (the hiddenSeries Vega signal, series disappearing from the chart) are unchanged. S1 behavior is unaffected.
Types of changes
Checklist: