Skip to content

feat: update stroke dash for dotted line type in s2 to render as circles#827

Open
madelineluke wants to merge 1 commit into
mainfrom
feat/s2-line-dots-as-circles
Open

feat: update stroke dash for dotted line type in s2 to render as circles#827
madelineluke wants to merge 1 commit into
mainfrom
feat/s2-line-dots-as-circles

Conversation

@madelineluke

Copy link
Copy Markdown
Collaborator

Description

Updating the dotted stroke dash array to create a circle. [0,4] draws a 0px stroke that renders as a point, with a 4px gap.

Related Issue

Motivation and Context

After applying lineCap: round in s2, the dotted line type was rendering each line mark as an oval pill shape, rather than circles.

How Has This Been Tested?

Unit tests and visual testing in storybook.

Screenshots (if appropriate):

Screenshot 2026-06-17 at 1 57 38 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant