feat: update stroke dash for dotted line type in s2 to render as circles#827
Open
madelineluke wants to merge 1 commit into
Open
feat: update stroke dash for dotted line type in s2 to render as circles#827madelineluke wants to merge 1 commit into
madelineluke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the dotted stroke dash array to create a circle. [0,4] draws a 0px stroke that renders as a point, with a 4px gap.
Related Issue
Motivation and Context
After applying
lineCap: roundin s2, the dotted line type was rendering each line mark as an oval pill shape, rather than circles.How Has This Been Tested?
Unit tests and visual testing in storybook.
Screenshots (if appropriate):
Types of changes
Checklist: