feat: add VPC configuration support via helix-deploy 13.4#209
Merged
alinarublea merged 3 commits intomainfrom Apr 20, 2026
Merged
feat: add VPC configuration support via helix-deploy 13.4#209alinarublea merged 3 commits intomainfrom
alinarublea merged 3 commits intomainfrom
Conversation
Add declarative VPC attachment configuration to package.json using new helix-deploy 13.4+ CLI flags. This replaces manual AWS console VPC setup with infrastructure-as-code approach. Changes: - Add awsVpcSubnetIds with VPC_SUBNET_1 and VPC_SUBNET_2 env var references - Add awsVpcSecurityGroupIds with VPC_SG_ID env var reference Note: GitHub repo secrets need to be configured for each environment (dev/stage/prod) with values from Terraform outputs before deployment. Related: adobe/helix-deploy#898 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
This PR will trigger a minor release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
solaris007
approved these changes
Apr 20, 2026
Member
solaris007
left a comment
solaris007
left a comment
There was a problem hiding this comment.
Hey @alinarublea, approving - declarative VPC attachment via helix-deploy 13.4 flags is the right call, and the env-var references for subnet/SG IDs keep per-environment values out of source. Just make sure the three repo secrets (VPC_SUBNET_1, VPC_SUBNET_2, VPC_SG_ID) are populated in dev/stage/prod before the first deploy, otherwise helix-deploy will detach the function from the VPC.
Replaces the standalone ci.yaml with a thin caller of adobe/mysticat-ci/service-ci.yaml@v2. vpc-enabled: true activates the declarative VPC attachment path using package.json hlx awsVpcSubnetIds / awsVpcSecurityGroupIds already in this PR. v2 adds the pre-deploy sanity check (catches missing secrets or missing hlx fields), aws lambda wait function-updated (closes the ENI eventual-consistency race), and the Verify Lambda VPC attachment step. Notes: - upload-build-artifacts (S3 artifact upload that existed in the previous standalone ci.yaml) is not part of the reusable workflow and is dropped here, matching the api-service and jobs-dispatcher migrations already landed on main. If a downstream consumer needs the artifact, restore it in a separate workflow. - Pilot validation of the v2 flow was completed on spacecat-jobs-dispatcher (branch-deploy in dev) and spacecat-api-service (deploy-stage + semantic-release to prod). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alinarublea
temporarily deployed
to
dev-branches
GitHub Actions
Inactive
…oy-13.4 # Conflicts: # .github/workflows/ci.yaml
alinarublea
had a problem deploying
to
dev-branches
GitHub Actions
Failure
alinarublea
had a problem deploying
to
dev-branches
GitHub Actions
Failure
alinarublea
temporarily deployed
to
dev-branches
GitHub Actions
Inactive
solaris007
pushed a commit
that referenced
this pull request
Apr 20, 2026
# [1.15.0](v1.14.6...v1.15.0) (2026-04-20) ### Bug Fixes * **deps:** update adobe fixes ([#255](#255)) ([0b8b9c9](0b8b9c9)) * **deps:** update adobe fixes ([#256](#256)) ([037446d](037446d)) * **deps:** update adobe fixes ([#260](#260)) ([6f28cb3](6f28cb3)) * **deps:** update external fixes ([#257](#257)) ([6d9d15a](6d9d15a)) * **deps:** update external fixes ([#262](#262)) ([431bec0](431bec0)) ### Features * add VPC configuration support via helix-deploy 13.4 ([#209](#209)) ([20a167f](20a167f)), closes [adobe/helix-deploy#898](adobe/helix-deploy#898)
Member
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
awsVpcSubnetIdsarray withVPC_SUBNET_1andVPC_SUBNET_2env var referencesawsVpcSecurityGroupIdsarray withVPC_SG_IDenv var referenceRequired Actions
Before deploying, configure GitHub repo secrets for each environment (dev/stage/prod):
VPC_SUBNET_1- VPC subnet ID 1 (from Terraform outputs)VPC_SUBNET_2- VPC subnet ID 2 (from Terraform outputs)VPC_SG_ID- VPC security group ID (from Terraform outputs)Test Plan
Related
🤖 Generated with Claude Code