feat(styles): add extra styles for homepage#65
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
| box-shadow: | ||
| inset 0 0 3px 0 rgb(from var(--header-inner-shadow) r g b / 65%), | ||
| 0 0 1px 0 rgb(from var(--header-outer-shadow) r g b / 10%), | ||
| 0 9px 95px 0 rgb(from var(--header-outer-shadow) r g b / 5%); |
There was a problem hiding this comment.
the shadows were removed from the prototype while design continues to refine the aether aesthetic.
| padding-block-start: calc(var(--button-padding-block-start) - var(--button-border-width)); | ||
| /* stylelint-disable-next-line declaration-block-no-redundant-longhand-properties */ | ||
| padding-block-end: calc(var(--button-padding-block-end) - var(--button-border-width)); |
There was a problem hiding this comment.
I think these calcs are easier to read when they're separated, but have no issue combining them to avoid a disabled stylelint rule. 👍
| background-color: var(--button-background-color-hover); | ||
| border-color: var(--button-background-color-hover); |
There was a problem hiding this comment.
Am I overusing the hover custom prop? I'd rather have an individual prop for each interactive state (use the hover prop for :hover, use the key-focus prop for :focus-visible, etc), but the values are all identical and I like less code. The naming and semantic usage is bothering me a bit, that's all.
f3227c7 to
36dc124
Compare
| backdrop-filter: blur(128px); | ||
|
|
||
| @media (width >= 900px) { | ||
| backdrop-filter: unset; |
There was a problem hiding this comment.
I kept the blur on the small screen header since the content takes up most of the screen as would otherwise scroll under the icons.
| background: | ||
| var(--s2-home-gradient), | ||
| var(--se-body-background-color); | ||
| background-image: url('/img/assets/background-image-light.png'); |
There was a problem hiding this comment.
happy to rework anything if these images aren't performant enough. I'm a little concerned about the size being really slow to fetch.
There was a problem hiding this comment.
TODO: media/beta/light.png
|
|
||
| .dark-scheme { | ||
| color-scheme: dark; | ||
| background-image: url('/img/assets/background-image-dark.png'); |
There was a problem hiding this comment.
TODO: media/beta/dark.png and
|
🧱 BLOCKED: waiting on chris's homepage & nav updates as it effects the way we're going to render the BG images. |
Description
Adds reusable Spectrum-style button classes to the global stylesheet and restructures the home template's intro area into a centered hero with a pill-shaped banner.
.btnbase class using Spectrum 2 component tokens (sizing, radius, typography, transition timing) with configurable--button-*custom properties..btn-primary/.btn-accent:hover/:focus-visible/:activestates driven by the--button-background-color-hovertoken.Home template (
templates/home/home.css,templates/home/home.js)home-columntohome-heroand lays it out as a centered flex column..home-bannerpill (inline-flex, rounded, translucent blue border/background usingrgb(from …)relative color syntax).80chand aligns any banner icon (svg) inline with its text.Screenshots (if applicable)
mainhomepage, missing stylesdraft homepage, new styles

Type of change
Related issue(s)
Validation steps
To Validate
URL for testing:
https://homepage-tweaks--spectrum-hub--adobe.aem.page/drafts/mhuysentruyt/homepage-test
npm testand confirm all tests passnpm run lintand confirm no linting errorsaem up.btn.btn-primaryand.btn.btn-accent; confirm sizing, radius, and text color match Spectrum specs.Accessibility testing checklist
Keyboard
Tabthrough the page..btnrendered as a link/button receives focus in logical order, shows a visible:focus-visibleindicator, and activates withEnter(andSpacefor buttons). The.home-banneris non-interactive text/icon content — confirm it is not a focus stop and does not introduce a trap.Screen reader
svgin the banner is not announced (or is properly labeled if meaningful); button variants announce role + accessible name.Device review
Checklist: