Skip to content

Ty#954

Open
armanddidierjean wants to merge 9 commits intoruff-0.15.10from
ty
Open

Ty#954
armanddidierjean wants to merge 9 commits intoruff-0.15.10from
ty

Conversation

@armanddidierjean
Copy link
Copy Markdown
Member

@armanddidierjean armanddidierjean commented Feb 9, 2026

Description

Summary

Typecheck the codebase using ty in addition to mypy.

Ty was able to detect multiples type related issues in our current codebase that are fixed by this pull request. This pull request will also allow developpers to use Ty to typecheck their code in realtime during development.

Mypy is still able to detect some issues that Ty don't catch, and there are still a few bugs in Ty. The idea of this pull request is thus to run both typecheckers in the CI

Required PRs

Requires #986

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 78.75000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.42%. Comparing base (c3b349f) to head (c0acdc6).

Files with missing lines Patch % Lines
app/core/payment/endpoints_payment.py 88.88% 4 Missing ⚠️
app/core/payment/payment_tool.py 63.63% 4 Missing ⚠️
app/core/google_api/google_api.py 0.00% 2 Missing ⚠️
app/utils/initialization.py 33.33% 2 Missing ⚠️
app/core/mypayment/endpoints_mypayment.py 0.00% 1 Missing ⚠️
app/modules/amap/endpoints_amap.py 80.00% 1 Missing ⚠️
app/modules/raffle/endpoints_raffle.py 66.66% 1 Missing ⚠️
app/types/websocket.py 0.00% 1 Missing ⚠️
app/utils/communication/notifications.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           ruff-0.15.10     #954      +/-   ##
================================================
- Coverage         84.42%   84.42%   -0.01%     
================================================
  Files               206      206              
  Lines             14912    14924      +12     
================================================
+ Hits              12590    12600      +10     
- Misses             2322     2324       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant