Visual: add real Water motion, foam, and atmospheric fog - #88
Closed
ael-dev3 wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 22, 2026
Owner
Author
|
Superseded by #95. The released water presentation is retained; the unused proof helper and standalone design prose were intentionally omitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft adds the renderer-only Water presentation layer requested by PR 5. It starts from protected
mainat582441671f7ad41158ef7117d28985608d3fa96aand ends ata68fa1b58ee894ee5796d831a6a90ac2d79ff57a.A separate PR-4 head was not present in the remote refs when this work started. The branch therefore uses the reviewed Water v1/revision-v1 foundation on protected
main; it does not copy an unreviewed candidate branch. The canonical Water rows, topology, layout/revision digests, activation state, and authority paths are unchanged.What was wrong
The previous layer used duplicated center-plus-six-corner hexes, filled river hexes, fixed regime colors, upward normals, and fragment-only sine glimmer. Its fog path blended only 62% toward the horizon, so full-fog cells were not guaranteed to become identical to the fog background. A translucent skirt hid the edge mechanically, and Water time was driven only by local elapsed scheduler time.
What changed
realm_environment_v1.updatedAtthrough the validated client projection. No schema, generated binding, topology, seed, or revision activation change is included.Budgets and measured assertions
The focused geometry tests assert all quality ceilings, finite flow attributes, connected/subdivided surfaces, continuous 12-ribbon coverage (800 ribbon triangles for the 400 active river cells), full-fog attributes, disposal, and triangle-to-cell selection mapping.
Fog/boundary proof
proveRealmWaterBoundaryCoverageis a pure QA helper that requires the two-cell hidden buffer, a maximum legal wave displacement of 0.35, and curtain bounds covering the projected vertical range. The shader sets the final Water lighting input to the fog horizon when the canonical fog factor is 1. Full-fog selection is rejected before interaction dispatch.Validation
Passed:
tsc --noEmit -p tsconfig.app.json;tsc -b --force;git diff --check.The full repository suite ran with 1,731 passing tests. Twenty unrelated subprocess/browser-boundary assertions failed because this sandbox denies loopback
listenfor the existingtsxand local browser probes (EPERM); none are in the changed Water path. The rendered WebGL harness was also run and failed closed for the same loopback/browser boundary, so no screenshots or clips are attached from this environment. Please rerun the repository browser matrix on a host with local Chrome and loopback permissions, including 1920x1080, 1280x720, tablet, 390x844, reduced quality, reduced motion, fog-depth sectors, river source/mouth, and selection cases.Non-goals
No SpacetimeDB publication, Water reseed, revision activation, schema expansion, topology change, passability/movement/resource/worker/combat rule, lake restoration for the active revision, boats, swimming, fishing, bridges/fords, currents, flooding, weather, naval combat, WebGPU/FFT migration, copied external shader/art, Pages deploy, tag, release, or merge.
Residual risks