feat(151): add long-running-operation example#66
Merged
Conversation
current errors: example/bookstore/v1/bookstore.proto:5:8:import "aep/api/operation.proto": file does not exist
now that proto generation has been properly upstreamed, we can leverage LROs from the aep-lib-go instead. This vastly reduces the code in aepc.
toumorokoshi
force-pushed
the
yft/lro2
branch
4 times, most recently
from
ab91d47 to
3297266
Compare
rambleraptor
approved these changes
Apr 29, 2025
This was referenced Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an example of a long-running-operation (archiveBook), to illustrate how LROs would work from a user interface standpoint.
This change currently implements the google.aip.Operation service to return the operation resource - in the future this will be replaced by an operation service that will be generated by aep-lib-go/aepc.
This change also upstreams the proto generation functionality, as well as the resource model for aepc, up to aep-lib-go. This simplifies end-to-end testing of changes to the resource model, as well as it's maintenance.