feat(aepc): expanding bookstore example#68
Merged
Conversation
The bookstore was missing stores and items - things that would be pretty critical for a bookstore. Adding those missing resources.
rambleraptor
reviewed
May 8, 2025
Member
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
It might be worth putting an "this is autogenerated" header comment on the example files.
rambleraptor
approved these changes
May 8, 2025
Member
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
Meant to approve this. My comment was a nit.
Member
Author
good call! I can do it for the proto at least. will tackle in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bookstore was missing stores and items - things that would be pretty critical for a bookstore. Adding those missing resources.