AER-1237: Replace streamflyer-core in imaer-gml#377
Merged
RonniLin merged 1 commit intoaerius:mainfrom Mar 27, 2026
Merged
Conversation
BertScholten
approved these changes
Mar 27, 2026
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
LGTM
Did you compare performance as well, or want to merge it first? (with calculator using a released version on main currently, now is a good moment to compare)
source/imaer-gml/src/main/java/nl/overheid/aerius/importer/ImaerImporter.java
Show resolved
Hide resolved
Contributor
Author
|
I didn’t compare performance, but seeing how little overhead there is it should be fine. I did try do in a ‘unit test’ setup, but it would best to test it in an running environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.