Repository navigation
MSVC TCP throughput fixes for P2pStream (IOCP recv/send pending, queue prefix, 65536 B Win recv) - #561
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Set is_recv_pending_ when WSARecv returns success so IOCP OnRead can deliver bytes through HandleRecv without dropping sync completions.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep per-frame WriteAction completion as sent_offset crosses segment ends; host stays inflight until the merged buffer is fully sent. Co-authored-by: Cursor <cursoragent@cursor.com>
Emit host frame status without Action::Finish until all segment tasks complete; add queue regression tests in test-transport. Co-authored-by: Cursor <cursoragent@cursor.com>
Track send_started_ before Send even when zero bytes are written; add pending-socket regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
…tity. Absorb by reference with batch_host_ delegation; merge only data buffers and clear host links when the batch Action finishes. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace index walk with repeated front pop; add queue regression tests for finished/pending/finished ordering. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore single-frame SendAction; keep PacketQueueManager finished-prefix pop and WinTcpSocket 65536 recv buffer. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…r sizing. Co-authored-by: Cursor <cursoragent@cursor.com>
…des and add queue regressions. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Throughput (harness single-pair topology 1b, external bench)
Payload 64512 B, inflight 8, 65536 B recv: median active goodput ~10.28 MiB/s; successful runs ~10.8-11.5 MiB/s vs prior stuck low single-digit MiB/s before these client fixes.
Test plan
Made with Cursor