Test/2026 05 12 lark bot reply chain regressions#651
Merged
eanzhao merged 8 commits intoMay 15, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feature/lark-bot #651 +/- ##
====================================================
+ Coverage 72.50% 72.55% +0.05%
====================================================
Files 1286 1297 +11
Lines 95060 96651 +1591
Branches 12428 12658 +230
====================================================
+ Hits 68920 70124 +1204
- Misses 21179 21470 +291
- Partials 4961 5057 +96
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #633.
This change adds focused regression coverage for the lark-bot reply chain on
feature/lark-bot, covering the current follow-up scope from:What changed
#635 AgentRunGAgent regression coverage
Added basic combination regressions around terminal and cleanup behavior:
AgentRunCleanupRequested.RunIddoes not match the terminal runLlmReplyReadyEventafter a terminal failed fallback reply has already been produced and deliveredThese assertions are aligned with the current contract:
terminal failure after successful fallback delivery remains
ReplyProduced + ReplyDispatched + ProducedTerminalState=Failed,rather than
Status=Failed.#636 TurnStreamingReplySink targeted race regressions
Added two sink-level race regressions:
Dispose()whileFinalizeAsync()is waiting for drain unblocks correctly and does not dispatch the stashed final flushThis keeps the sink coverage focused on real race-prone paths instead of broad coverage expansion.
#637 dispatcher seam + generator basics
Added:
ConversationGAgenton theIChannelLlmReplyRunDispatcherseam and prevents direct references to concrete run/inbox runtime typesSkillRegistryis present withoutIRemoteSkillFetchertoolmessage is issuedAlso tightened naming/intent so the tests describe the current verified contract, not a stronger target-state contract.
Audit doc update
Updated the reply-chain audit document to reflect the current test reality:
ChatRuntimeterminal chunk behavior is still a target-state question, not an accepted current contractVerification
test/Aevatar.GAgents.ChannelRuntime.Testsfiltered to
AgentRunGAgentTests | ConversationReplyGeneratorTests | TurnStreamingReplySinkTeststest/Aevatar.Architecture.Testsfiltered to the dispatcher seam guard test
bash tools/ci/test_stability_guards.shResults:
Notes
This change intentionally does not modify
ChatRuntimeproduction behavior.It only adds/adjusts tests and audit documentation against the currently accepted behavior on this branch.