Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/auto-pr-from-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
git config --global user.email "github-actions[bot]@users.noreply.github.com"

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1
with:
dotnet-version: "10.0.x"

Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
git config --global user.email "github-actions[bot]@users.noreply.github.com"

- name: �️ Setup .NET
uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1
with:
dotnet-version: "10.0.x"

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Floating major tag narrowed to pinned minor version

In ci-build-test.yml, publish-all.yml, and security-scan.yml, the reference was changed from actions/setup-dotnet@v5 (a floating major tag that automatically picks up new minor/patch releases like v5.5.0, v5.6.0, etc.) to actions/setup-dotnet@v5.4.0 (pinned to exactly v5.4.0). This means these workflows will no longer receive automatic minor or patch updates to the action. This is likely intentional for reproducibility, but it does mean future action improvements or fixes won't be picked up without another explicit version bump PR.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
dotnet-version: ${{ env.DOTNET_VERSION }}

Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0
with:
dotnet-version: ${{ env.DOTNET_VERSION }}

Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
uses: actions/checkout@v7

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0
with:
dotnet-version: ${{ env.DOTNET_VERSION }}

Expand All @@ -205,7 +205,7 @@ jobs:
uses: actions/checkout@v7

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0
with:
dotnet-version: ${{ env.DOTNET_VERSION }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
uses: NuGet/setup-nuget@fd55a6f3b34392fa83fde1454582407d8c714123

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1
with:
dotnet-version: "10.0.x"

Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1
with:
dotnet-version: "10.0.x"

Expand Down Expand Up @@ -215,7 +215,7 @@ jobs:
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1
with:
dotnet-version: "10.0.x"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
fetch-depth: 0

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0
with:
dotnet-version: ${{ env.DOTNET_VERSION }}

Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
uses: actions/checkout@v7

- name: ️ Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0
with:
dotnet-version: ${{ env.DOTNET_VERSION }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/security-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
uses: actions/checkout@v7

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Mixed pinning strategies across workflow files

The repository uses two different pinning strategies for the same action: SHA-pinned commits in auto-pr-from-main.yml and code-quality.yml (actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1), and version tags in ci-build-test.yml, publish-all.yml, and security-scan.yml (actions/setup-dotnet@v5.4.0). This is a pre-existing inconsistency that the PR preserves. SHA pinning is generally considered more secure (immune to tag mutation), so the version-tagged files have a weaker guarantee. Consider standardizing on SHA pinning across all workflows for consistency.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
dotnet-version: "10.0.x"

Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
uses: NuGet/setup-nuget@v4

- name: 🗄️ Setup .NET
uses: actions/setup-dotnet@v5
uses: actions/setup-dotnet@v5.4.0
with:
dotnet-version: "10.0.x"

Expand Down
Loading