fix E2E tests#330
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Codex ACP E2E test suite to be less sensitive to Codex model-catalog drift, improving reliability as Codex is upgraded.
Changes:
- Updated the “other” test model ID used by E2E fixtures.
- Reworked the models-availability E2E to assert a stable invariant (current/default model’s base id is present among advertised models) instead of pinning a specific model id.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/CodexACPAgent/e2e/spawned-agent-fixture.ts | Updates the secondary (“other”) model ID used by E2E tests. |
| src/tests/CodexACPAgent/e2e/acp-e2e-models-availability.test.ts | Makes the default-model availability assertion resilient to catalog changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
+13
| export const DEFAULT_TEST_MODEL_ID = ModelId.create("gpt-5.2", "none"); | ||
| export const OTHER_TEST_MODEL_ID = ModelId.create("gpt-5.4-mini", "low"); | ||
| export const OTHER_TEST_MODEL_ID = ModelId.create("gpt-5.5", "low"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.