Fix pending request cleanup and improve IO fairness#107
Open
anaslimem wants to merge 1 commit intoagentclientprotocol:mainfrom
Open
Fix pending request cleanup and improve IO fairness#107anaslimem wants to merge 1 commit intoagentclientprotocol:mainfrom
anaslimem wants to merge 1 commit intoagentclientprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a pending-response leak and improves IO fairness in the RPC layer. It introduces a
PendingRequestfuture that cleans up on drop, switches from biased to unbiased select in the IO loop, and adds a targeted edge-case test to verify cleanup behavior. A small test-only accessor was added to support the new test.Changes
PendingRequestfuture withDropcleanup to preventpending_responsesfrom growing when requests are canceled or dropped.select_biased!withfutures::select!in the IO loop to avoid incoming starvation under heavy outgoing traffic.debugsince dropped requests are now expected.test_pending_response_cleanup_on_dropto validate cleanup.pending_response_count()accessor.Why