fix: refuse to issue trace claim when hardware TEE session report is missing - #426
Open
qubeena07 wants to merge 1 commit into
Open
fix: refuse to issue trace claim when hardware TEE session report is missing#426qubeena07 wants to merge 1 commit into
qubeena07 wants to merge 1 commit into
Conversation
…missing When the per session TEE attestation call failed, close_session still fell back to the shared startup report and signed a claim anyway. That report carries no chain root commitment, so a strict verifier rejects it, but the runtime handed it out as if everything was fine. Now on a hardware platform this path raises TeeFault instead of issuing an unbound claim. Software only dev mode keeps the old fallback behavior since that binding was already best effort there. Fixes agentrust-io#372 Signed-off-by: Dipika Ranabhat <qubeena7@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #372.
When the per session TEE attestation call failed inside create_session, close_session still fell back to the shared startup report and signed a claim off of it. That startup report carries no chain root commitment, so a strict verifier already rejects it, but the runtime handed the claim out anyway as if nothing was wrong.
This change makes close_session raise TeeFault instead of issuing that unbound claim, but only when the platform is a real hardware TEE. In software only dev mode the fallback still succeeds, since that binding was already best effort there and this is not a regression for that path.
Changes
Test plan