Skip to content

fix(sandbox): serialize only sandboxId to prevent Jackson circular dependency #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itxaiohanglover wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix(sandbox): serialize only sandboxId to prevent Jackson circular dependency #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sandbox-core/src/main/java/io/agentscope/runtime/sandbox/manager/SandboxService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public ContainerModel createContainer(Sandbox sandbox) throws JsonProcessingExce
if (this.remoteHttpClient != null) {
logger.info("Creating container in remote mode via RemoteHttpClient");
ObjectMapper mapper = new ObjectMapper();
String sandboxJson = mapper.writeValueAsString(sandbox);
String sandboxJson = mapper.writeValueAsString(Map.of("sandboxId", sandbox.getSandboxId()));
Map<String, Object> request = Map.of("sandbox", sandboxJson);
Object result = remoteHttpClient.makeRequest(
RequestMethod.POST,
Expand Down Expand Up @@ -536,7 +536,7 @@ public ContainerModel getInfo(Sandbox sandbox) throws JsonProcessingException {
if (this.remoteHttpClient != null) {
logger.info("Getting sandbox info in remote mode via RemoteHttpClient");
ObjectMapper mapper = new ObjectMapper();
String sandboxJson = mapper.writeValueAsString(sandbox);
String sandboxJson = mapper.writeValueAsString(Map.of("sandboxId", sandbox.getSandboxId()));
Map<String, Object> request = Map.of("sandbox", sandboxJson);
Object result = remoteHttpClient.makeRequest(
RequestMethod.POST,
Expand Down Expand Up @@ -599,7 +599,7 @@ public Map<String, Object> listTools(Sandbox sandbox, String toolType) throws Js
if (this.remoteHttpClient != null) {
logger.info("Listing tools in remote mode via RemoteHttpClient");
ObjectMapper mapper = new ObjectMapper();
String sandboxJson = mapper.writeValueAsString(sandbox);
String sandboxJson = mapper.writeValueAsString(Map.of("sandboxId", sandbox.getSandboxId()));
Map<String, Object> request = Map.of(
"sandbox", sandboxJson,
"toolType", toolType
Expand Down Expand Up @@ -630,7 +630,7 @@ public String callTool(Sandbox sandbox, String toolName, Map<String, Object> arg
if (this.remoteHttpClient != null) {
logger.info("Calling tool in remote mode via RemoteHttpClient");
ObjectMapper mapper = new ObjectMapper();
String sandboxJson = mapper.writeValueAsString(sandbox);
String sandboxJson = mapper.writeValueAsString(Map.of("sandboxId", sandbox.getSandboxId()));
Map<String, Object> request = Map.of(
"sandbox", sandboxJson,
"toolName", toolName,
Expand Down Expand Up @@ -660,7 +660,7 @@ public Map<String, Object> addMcpServers(Sandbox sandbox, Map<String, Object> se
if (this.remoteHttpClient != null) {
logger.info("Adding MCP servers in remote mode via RemoteHttpClient");
ObjectMapper mapper = new ObjectMapper();
String sandboxJson = mapper.writeValueAsString(sandbox);
String sandboxJson = mapper.writeValueAsString(Map.of("sandboxId", sandbox.getSandboxId()));
Map<String, Object> request = Map.of(
"sandbox", sandboxJson,
"serverConfigs", serverConfigs,
Expand Down