-
Notifications
You must be signed in to change notification settings - Fork 3
UI upgraded to Ink with fixed positions and more UX tweaks #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasonkneen
wants to merge
1
commit into
agentuity:main
Choose a base branch
from
jasonkneen:feature-tui-ux-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": ["Bash(bun run format:*)", "Bash(node -e:*)", "Bash(node -p:*)"], | ||
| "deny": [], | ||
| "ask": [] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Restrict
node -eandnode -ppatterns or move toaskarray.The
node -e:*andnode -p:*patterns are overly permissive. The-eand-pflags allow arbitrary JavaScript code execution, and the*wildcard places no constraints on what code can run. This creates a significant attack surface if Claude or an AI assistant executes these commands during development.Recommended actions:
askarray to require user confirmation before execution.node -e:console.log(*)or other restricted code patterns.Clarify: Is this configuration file intended only for local development, and will it be committed to the repository? If yes, consider the security implications for other developers who clone the repo.
🏁 Script executed:
Length of output: 368
🏁 Script executed:
Length of output: 4361
Remove or restrict
node -e:*andnode -p:*patterns in version-controlled configuration.The
.claude/settings.local.jsonfile is committed to version control and shared with all repository contributors. The patternsBash(node -e:*)andBash(node -p:*)allow arbitrary JavaScript code execution without restrictions, contradicting the project's stated security model ("Command whitelisting - Only safe shell commands allowed").Required actions:
askarray to require user confirmation, or remove them entirely if not essential.The file being shared across all developers amplifies the risk surface.
🤖 Prompt for AI Agents