🔧 deps: fix Dependabot security alerts (#60, #64, #65, #66, #67)#317
Merged
Conversation
Alert #60: body-parser 2.x prior to 2.3.0 silently disables request size enforcement when given an invalid `limit` option, allowing a DoS. Add a pnpm.overrides entry (body-parser@2 -> ^2.3.0) to force the transitive resolution to the patched version without touching any direct dependency declarations.
…ides to patched versions (GHSA fixes) - Alert #67: body-parser 1.x < 1.20.6 DoS via invalid `limit` value silently disabling size enforcement -> pinned to ^1.20.6 - Alert #66: webpack-dev-server <= 5.2.5 CSRF via internal developer endpoints -> pinned to ^5.2.6 - Alert #65: webpack-dev-server <= 5.2.5 DoS via malformed Host/Origin header -> pinned to ^5.2.6 - Alert #64: shell-quote <= 1.8.4 quadratic-complexity DoS in parse() -> pinned to ^1.9.0 (tightened from the existing >=1.8.4 override) All three are transitive build-tooling dependencies pulled in via the Docusaurus toolchain; fixed via pnpm.overrides, no direct dependency versions changed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 5 open Dependabot security alerts across two separate pnpm workspaces in this repo (root SDK and
website/) by forcing pnpm's transitive dependency resolution to patched versions viapnpm.overrides. No direct dependency versions in eitherpackage.jsonwere changed.Root
pnpm-lock.yamlbody-parser(2.x) DoS: an invalidlimitvalue silently disables request size enforcement. Vulnerable>= 2.0.0, < 2.3.0, patched2.3.0. Fix: added"body-parser@2": "^2.3.0"to rootpnpm.overrides.website/pnpm-lock.yamlbody-parser(1.x) same DoS class as Bump @napi-rs/cli from 3.6.2 to 3.7.0 #60. Vulnerable< 1.20.6, patched1.20.6. Fix: added"body-parser@1": "^1.20.6"override.webpack-dev-serverCSRF via internal developer endpoints. Vulnerable<= 5.2.5, patched5.2.6. Fix: bumped existingwebpack-dev-serveroverride from^5.2.4to^5.2.6.webpack-dev-serverDoS via malformed Host/Origin header. Same vulnerable/patched range as [AAASM-2336] ♻️ (release-node): Listen for repository_dispatch from agent-assembly; remove retry workaround #66, resolved by the same override bump.shell-quotequadratic-complexity DoS inparse(). Vulnerable<= 1.8.4, patched1.9.0. Fix: tightened existingshell-quoteoverride from>=1.8.4to^1.9.0.Why
All 5 packages are transitive dependencies pulled in by other tooling (body-parser via express-family packages; webpack-dev-server/shell-quote via the Docusaurus/webpack build toolchain in
website/). Usingpnpm.overridesforces the resolver to the patched versions without adding these as direct dependencies.How to verify
pnpm installregeneratespnpm-lock.yamlwithbody-parser@2.3.0resolved (was2.2.2).pnpm run build,pnpm run typecheck, andpnpm run test(631 passed, 2 pre-existing skips) all pass.pnpm install --no-frozen-lockfile --ignore-workspace(the documented install method forwebsite/, matching.github/workflows/publish-docs.yml) regenerateswebsite/pnpm-lock.yamlwithbody-parser@1.20.6,webpack-dev-server@5.2.6, andshell-quote@1.10.0resolved.pnpm run build(Docusaurus static build) andpnpm run typecheckboth pass.Closes #60, #64, #65, #66, #67