Skip to content

Updated chemistry-rdkit/SKILL.md with additional chemistry functions#252

Closed
alexarnimueller wants to merge 2 commits into
aiming-lab:mainfrom
alexarnimueller:main
Closed

Updated chemistry-rdkit/SKILL.md with additional chemistry functions#252
alexarnimueller wants to merge 2 commits into
aiming-lab:mainfrom
alexarnimueller:main

Conversation

@alexarnimueller
Copy link
Copy Markdown

  • QED and SAScore
  • InChI key
  • Maximum common substructure

alexarnimueller and others added 2 commits April 27, 2026 21:43
- QED and SAScore
- InChI key
- Maximum common substructure
- Fix MiniMax provider: use https://api.minimax.io/anthropic (was
  api.minimaxi.com/v1 which doesn't support Anthropic Messages endpoint)
- Add wire_api=anthropic to minimax preset for correct endpoint routing

- S2 (Semantic Scholar): on first 429, skip S2 immediately for that query
  instead of retrying with backoff. arXiv/OpenAlex can run while S2
  cools down, rather than blocking all backends behind S2 retries.
@Jiaaqiliu
Copy link
Copy Markdown
Collaborator

Hi @alexarnimueller, thanks for the chemistry SKILL.md improvements!

However, we noticed this PR includes undeclared code changes beyond the SKILL.md update:

  1. researchclaw/literature/semantic_scholar.py — adds early-bail logic on first S2 429 response
  2. researchclaw/llm/__init__.py — changes minimax base_url from api.minimaxi.com/v1 to api.minimax.io/anthropic and adds a new wire_api: "anthropic" field

These code changes are not mentioned in the PR description and could introduce unintended behavior. The minimax URL change in particular would affect all users of the minimax provider.

Could you please either:

  1. Split this into separate PRs (one for the SKILL.md docs, one for each code change with proper testing/justification), or
  2. Remove the unrelated code changes and resubmit as a docs-only PR

We are happy to merge the SKILL.md updates once the unrelated changes are separated. Thanks!

@Jiaaqiliu
Copy link
Copy Markdown
Collaborator

Closing due to undeclared code changes mixed with doc updates. Please split into separate PRs — happy to merge the SKILL.md updates separately.

@Jiaaqiliu Jiaaqiliu closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants