fix(deps): bump golang.org/x/crypto to v0.54.0 for CVE-2026-46595 (GO-2026-5023)#197
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
fix(deps): bump golang.org/x/crypto to v0.54.0 for CVE-2026-46595 (GO-2026-5023)#197devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…-2026-5023) Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the transitive dependency
golang.org/x/cryptofromv0.30.0tov0.54.0(>= the advisory's fixedv0.52.0) to clear Go advisory GO-2026-5023 / CVE-2026-46595 from the publishedabctlbinary.golang.org/x/cryptoremains an// indirectdependency.Reachability (not exploitable in abctl)
The vulnerable code path in GO-2026-5023 is in
golang.org/x/crypto/sshserver-side authentication (ssh.NewServerConn/ server permission-callback enforcement). abctl does not importgolang.org/x/crypto/sshanywhere — verified viago list -deps ./..., which pulls in only theopenpgp,bcrypt,scrypt,pbkdf2,chacha20poly1305(and their internal) subpackages for Helm chart/provenance and TLS. So the actual exploitability in abctl is effectively nil; this bump exists to clear the advisory match on the published binary, not to close a reachable exploit.Cascading changes
golang.org/x/crypto@v0.52.0+requiresgo >= 1.25.0, sogo mod tidycascaded:godirective upgraded1.23.4→1.25.0golang.org/x/*modules bumped (net,sys,term,text,tools,mod,sync).github/workflows/airbox-release.ymlGo version pin bumped1.24→1.25so release builds use a compatible toolchain. The other workflows (go.yml,release.yml) already usego-version: 'stable', which resolves to the latest 1.25.x — no change needed.Declarative-First Evaluation
N/A — this is a dependency/version bump in a Go CLI, not a declarative (YAML manifest-only) Airbyte connector change.
Test Coverage
No new test is added: this is a dependency-version-only change with no new runtime behavior to cover. Verified locally with Go 1.25.12:
go build ./...succeedsgo test ./...passes (all packagesok)go.mod/go.sumembedgolang.org/x/crypto v0.54.0(indirect)Note on release
The actual release/publish of a patched
abctlbinary is a separate maintainer action beyond this PR — merging this only updates the source. A maintainer must cut a new release for the fix to reach the published binary. The Go toolchain upgrade to 1.25 is the main item worth maintainer review.Related to https://github.com/airbytehq/oncall/issues/13109:
Link to Devin session: https://app.devin.ai/sessions/1e5af4641778465fac71d8d89e702975