Repository navigation
(Svelte) Render unmapped MDI icons in the Svelte client - #84
Merged
alexanderoster merged 1 commit intoOct 21, 2026
Merged
Conversation
config.xml names icons by MDI name ("mdi-library"), and vue2 ships the
whole @mdi/font, so any MDI name works there. The Svelte client maps
names to lucide icons through a short table and drew an empty circle
for everything else. The example configs hit the same gap.
Names missing from the table now render from @mdi/font, the same font
vue2 uses. The lucide table stays, so mapped icons look as before. The
glyph is sized from the caller's h-*/w-* box (font-size 100cqh in a
size container), so call sites are unchanged. Names that are not
"mdi-[a-z0-9-]+" still get the circle, which keeps config values out
of the class list.
The lockfile carries only the @mdi/font entries; npm would also have
rewritten unrelated "dev" flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.xml names icons by MDI name ("mdi-library"), and vue2 ships the whole @mdi/font, so any MDI name works there. The Svelte client maps names to lucide icons through a short table and drew an empty circle for everything else. The example configs hit the same gap.
Names missing from the table now render from @mdi/font, the same font vue2 uses. The lucide table stays, so mapped icons look as before. The glyph is sized from the caller's h-/w- box (font-size 100cqh in a size container), so call sites are unchanged. Names that are not "mdi-[a-z0-9-]+" still get the circle, which keeps config values out of the class list.
NB: Adding @mdi/font as a devDependency
The lockfile carries only the @mdi/font entries; npm would also have rewritten unrelated "dev" flags.