Repository navigation
Add telemetry off-switch to amc_server.xml - #87
Merged
alexanderoster merged 1 commit intoOct 23, 2026
Merged
Conversation
Telemetry recording is unconditional and unbounded: every state machine state and signal slot records on every cycle, which can reach gigabytes per day and fill the disk of a long-running machine. Add an optional telemetry attribute on the <data> node: <data directory="data/" database="sqlite" sqlitedb="storage.db" telemetry="off" /> "on" or omitted keeps current behaviour; "off" creates no telemetry_*.data file and writes no entries; any other value fails at startup with INVALIDTELEMETRYSETTING. The flag is passed via new DataModel::SetTelemetryEnabled/GetTelemetryEnabled methods rather than a new InitialiseDatabase parameter, so a mismatched libmcdata fails with COULDNOTFINDLIBRARYEXPORT instead of misreading arguments, and existing InitialiseDatabase callers are unchanged. Entries are dropped in CTelemetryWriter::writeEntry, not at marker creation, because the signal slot reaction/finish/acknowledge timing parameters are computed from the in-memory marker statistics. Channel registration is also unchanged, so an "off" session stays readable by TelemetryReader. Retention of existing telemetry/journal files and the session_metrics table are out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telemetry recording is unconditional and unbounded: every state machine state and signal slot records on every cycle, which can reach gigabytes per day and fill the disk of a long-running machine. Add an optional telemetry attribute on the node:
"on" or omitted keeps current behaviour; "off" creates no telemetry_*.data file and writes no entries; any other value fails at startup with INVALIDTELEMETRYSETTING.
The flag is passed via new DataModel::SetTelemetryEnabled/GetTelemetryEnabled methods rather than a new InitialiseDatabase parameter, so a mismatched libmcdata fails with COULDNOTFINDLIBRARYEXPORT instead of misreading arguments, and existing InitialiseDatabase callers are unchanged.
Entries are dropped in CTelemetryWriter::writeEntry, not at marker creation, because the signal slot reaction/finish/acknowledge timing parameters are computed from the in-memory marker statistics. Channel registration is also unchanged, so an "off" session stays readable by TelemetryReader.
Retention of existing telemetry/journal files and the session_metrics table are out of scope.