Repository navigation
Conversation
e32f2c1 "Implemented Incremental List updates client side" made AMCModule_{AlertList,BuildList,ExecutionList}.js import ../common/AMCListDeltaSync.js, but the file was never committed, so neither the vue2 nor the svelte client builds from a clean checkout. This implements it from how the three modules use it and from the server side of the list delta protocol (7fb0f11): - notifyHeadID() is fed the *listheadid attribute; the first call fetches the full list, later ones fetch "?since=<last applied head>". - Delta rows are upserted by key, removedKeys dropped, entries re-sorted in place (the UI holds a reference to the array). - One request at a time; notifications during a request coalesce into one follow-up; a failed request is retried on the next notification. - A head that goes backwards (e.g. the alert journal after a server restart) triggers a full resync.
Owner
|
Apologies, I added the original file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e32f2c1 made three client modules import a file that was never committed, so neither the vue2 nor the svelte client builds from a clean checkout. This adds it.
Client/core/ ├── common/ +│ └── AMCListDeltaSync.js # full fetch, then ?since=<head> deltas └── modules/ ├── AMCModule_AlertList.js # import ../common/AMCListDeltaSync.js ├── AMCModule_BuildList.js # import ../common/AMCListDeltaSync.js └── AMCModule_ExecutionList.js # import ../common/AMCListDeltaSync.jsThe API comes from how these three modules call it. The behaviour follows the server's list delta protocol (7fb0f11): one request at a time, and a full resync when the head goes backwards.
Blast Radius: client-only
It changes only the alert, build and execution lists, which can't be built today anyway.