Repository navigation
(Svelte) Keep the System Logs page from scrolling the app bar away - #90
Merged
alexanderoster merged 1 commit intoOct 23, 2026
Merged
Conversation
The wrapper of a lone page module was not a flex container, so the logs module's flex-1 had no effect and it grew to its full content height. The page scrolled instead of the log, taking the app bar, log toolbar and table header with it and breaking scroll-to-latest. The wrapper is now a flex column, so the log stays within the page and scrolls itself. The sidebar ScrollArea lacked min-h-0, so on short screens the menu overflowed; clicking a low item scrolled the overflow-hidden root and pushed the app bar off screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper of a lone page module was not a flex container, so the logs module's flex-1 had no effect and it grew to its full content height. The page scrolled instead of the log, taking the app bar, log toolbar and table header with it and breaking scroll-to-latest. The wrapper is now a flex column, so the log stays within the page and scrolls itself.
The sidebar ScrollArea lacked min-h-0, so on short screens the menu overflowed; clicking a low item scrolled the overflow-hidden root and pushed the app bar off screen.