[codex] Fix async recorded move playback#3
Draft
OzasaHiro wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes recorded move playback from the async chat path by avoiding the synchronous
play_movewrapper when an event loop is already running.Root cause
ReachyMini.play_movewrapsasync_play_movewithasgiref.sync.async_to_sync. Inspeak_with_expression_parallel, recorded moves were executed directly inside an async function, which can raise:You cannot use AsyncToSync in the same thread as an async event loopChanges
_resolve_recorded_move.execute_recorded_movebehavior for sync callers.execute_recorded_move_asyncfor async callers, usingReachyMini.async_play_movewhen available.speak_with_expression_parallelto use the async-safe path.Validation
python -m py_compile emo_v6.py emo_v8.py.emo_v8.py --chat --model gemma4:e4b --piper-model models/en-us-blizzard_lessac-medium.onnx --gentle --debugagainst a local Reachy Mini simulator daemon.Quick move execution error: You cannot use AsyncToSync...no longer appears during the async chat response flow.