Repository navigation
fix(config): preserve zero primary model sampling weights - #533
Merged
codelion merged 1 commit intoOct 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy configuration loading and
rebuild_models()treatedprimary_model_weight: 0as a missing value and replaced it with1.0. Preserve zero so weighted generation selects the positive-weight secondary model instead. Omitted weights still default to1.0, and positive weights remain unchanged. Evaluator configurations that inherit these models also retain the explicit zero weight.Regression tests exercise constructor, YAML loading and rebuilding through the real seeded ensemble with synthetic recording clients. All three zero-weight paths select the wrong client before the fix. Validation: 36 focused tests passed; full Python 3.10 unit suite passed (792 passed, 2 skipped); Black and
git diff --checkpassed.Model initialization, all-model judge generation and all-zero-weight validation are unchanged. Implemented and tested with Codex assistance and independently reviewed by another Codex agent.