ci: support self hosted runner and remove comment trigger on code review actions#97
Open
stay-foolish-forever wants to merge 3 commits into
Open
Conversation
…workflows - Configure ocr-review.yml to use self-hosted runner with node:20 container - Configure release.yml build job to use self-hosted runner with golang:1.25 container - Configure release.yml release job to use self-hosted runner with ubuntu:24.04 container - Configure release.yml npm-publish job to use self-hosted runner with node:20 container - Remove explicit Node.js setup step in ocr-review.yml (container provides Node.js)
- deploy-pages: switch to self-hosted runner with node:20 container, remove redundant setup-node - release: bump golang image to 1.26.4, remove redundant setup-go - release: remove redundant setup-node in npm-publish job (node:20 image already includes Node 20) - release: add jq installation step for version injection in npm-publish
Remove the comment-based review trigger and all associated dead code: - Drop issue_comment event from workflow triggers - Remove Get PR context step (only needed for comment events) - Simplify checkout ref and fetch commands to use pull_request data directly - Remove unreachable else branches in shell and JS blocks - Update header comments to reflect PR-only trigger
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support running actions on self-hosted runners and remove comment trigger on code review actions to make actions list clean.
Type of Change
How Has This Been Tested?
make testpasses locallyChecklist
go fmt,go vet)Related Issues