Raise test coverage to ≥90% (Aone #84428597)#253
Merged
Conversation
Add targeted tests for logging, OkHttp CA/proxy paths, Tea helpers, and utils without relying on the CI CA secret.
yndu13
commented
Jul 20, 2026
| W/IXexXzHPe/L8FfZDD80EoEzM73D5GyhQtX488npULYyyPJTAfR5q4CHzbubq9m | ||
| kfOif6MH4s0sgDZkcPFNt5dTKj7OUIbVljINEcd6VP+I6m1Wb4vYOBttqQ9jLgLm | ||
| 8hc09omOX3/qlRvQuQbdGNaAwRLE8DNtdR9rFIG3Gm2MZaVwDwQnRaeF+uKcFL9u | ||
| MRIs49xwswJtg+AFGO6D |
Contributor
Author
There was a problem hiding this comment.
这些证书是否都是假的,如果是真的,不能直接写在代码里。
Contributor
Author
There was a problem hiding this comment.
确认:原先 PEM 是 CN=test.local 的自签测试夹具,不是生产证书,也未提交私钥。
为消除「真证书入库」疑虑,已删除 src/test/resources/test-ca*.pem,改为单测运行时用 keytool 生成 ephemeral 自签 CA(OU=UnitTestFixture),覆盖路径不变。请 re-review。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary