Use one SQL query to get all domains#4878
Merged
Merged
Conversation
Domains must have an organisation ID, so are always associated with an organisation: https://github.com/alphagov/notifications-api/blob/aee7023565123843ea614acd27fe473ed1bcb26a/app/models.py#L380 The previous query gets all the domains for all organisations, no matter whether they are archived, have no services, etc. This does the same thing but in one SQL query, rather than firing off one query per organisation.
joybytes
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domains must have an organisation ID, so are always associated with an organisation:
notifications-api/app/models.py
Line 380 in aee7023
The previous query gets all the domains for all organisations, no matter whether they are archived, have no services, etc.
This does the same thing but in one SQL query, rather than firing off one query per organisation.
Tested here:
notifications-api/tests/app/dao/test_organisation_dao.py
Lines 61 to 73 in aee7023