Log when non-compatible characters are replaced in text messages#4879
Merged
Conversation
quis
force-pushed
the
log-non-compatible-chars-sms
branch
from
5d69439 to
0094de4
Compare
joybytes
approved these changes
Jun 12, 2026
We want to know the risk of allowing all unicode characters in text messages. Existing templates won’t contain non-compatible characters because we validate them out. Personalisation can contain non-compatible characters but we replace each with a ? at the time of sending. We want to know how often this is happening, because our change would result in these characters not being encoded, but the message costing more. We don’t want to log the characters directly because that would mean putting personal data – if only a few characters — into our logs. So we log a count instead.
quis
force-pushed
the
log-non-compatible-chars-sms
branch
from
0094de4 to
d2914af
Compare
joybytes
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to know the risk of allowing all unicode characters in text messages.
Existing templates won’t contain non-compatible characters because we validate them out.
Personalisation can contain non-compatible characters but we replace each with a ? at the time of sending. We want to know how often this is happening, because our change would result in these characters not being encoded, but the message costing more.