Skip to content

Spdx tags: Use PSDX tags for this project #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinodkoul wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Spdx tags: Use PSDX tags for this project #7

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
21afc62
COPYING: Use SPDX tags
vinodkoul Sep 9, 2020
2f3fcaf
src: use SPDX tags in C files
vinodkoul Sep 9, 2020
e832243
include: use SPDX tags in H files
vinodkoul Sep 9, 2020
4a0a95e
tinycompress: use SPDX tags in build files
vinodkoul Sep 9, 2020
b4a5d80
utils-lgpl: Add COPYING file
vinodkoul Sep 9, 2020
0250d25
fcplay: update SDPX tag style
vinodkoul Sep 9, 2020
3b6fdbf
utils-lgpl: use SPDX tags in build files
vinodkoul Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/utils-lgpl/fcplay.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//SPDX-License-Identifier: LGPL-2.1-only
/* SPDX-License-Identifier: LGPL-2.1-only */

//Copyright (c) 2011-2012, Intel Corporation
Copy link
Copy Markdown
Contributor

@plbossart plbossart Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really confused as to whether this is indeed an Intel contribution. I don't think we added anything with LGPL-only, did we?

Copy link
Copy Markdown
Contributor Author

@vinodkoul vinodkoul Sep 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was derived from cplay.c (lots of code copy) hence the original copyright was retained by me and new one added

Copy link
Copy Markdown
Contributor

@plbossart plbossart Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. In that case, you should make it clearer. e.g.

Derived from cplay.c Copyright (c) 2011-2012, Intel Corporation

//Copyright (c) 2018-2019, Linaro Ltd
Copy link
Copy Markdown
Contributor

@plbossart plbossart Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Copy Markdown
Contributor Author

@vinodkoul vinodkoul Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style change

/* Copyright (c) 2011-2012, Intel Corporation */
/* Copyright (c) 2018-2019, Linaro Ltd */

#include <stdint.h>
#include <linux/types.h>
Expand Down