Make getting started guide rows clickable#455
Open
snehkagrana wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Getting Started guide disclosure rows so clicking the row text/label toggles each section, instead of only the chevron/down-arrow area responding.
This updates the three guide rows in
WelcomeViewto use a reusable button-backed disclosure row. The visual treatment remains the same: chevron, labels, feature badges, section content, reduce-motion animation handling, and accessibility expanded/collapsed values are preserved.Type of Change
Related Issues
Testing
swiftlint --strict --config .swiftlint.yml Sourcesswiftformat --config .swiftformat SourcesAdditional verification:
xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS' CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO— 48 tests passed, 0 failuresgit diff --checkNotes
swiftlintandswiftformatare not installed in this local environment, so those checks were not run.Button.Screenshots / Video
Not included. This is a small interaction-target fix with no intended visual change.