Skip to content

Make getting started guide rows clickable#455

Open
snehkagrana wants to merge 1 commit into
altic-dev:mainfrom
snehkagrana:codex/getting-started-row-click
Open

Make getting started guide rows clickable#455
snehkagrana wants to merge 1 commit into
altic-dev:mainfrom
snehkagrana:codex/getting-started-row-click

Conversation

@snehkagrana

Copy link
Copy Markdown

Description

Fixes the Getting Started guide disclosure rows so clicking the row text/label toggles each section, instead of only the chevron/down-arrow area responding.

This updates the three guide rows in WelcomeView to use a reusable button-backed disclosure row. The visual treatment remains the same: chevron, labels, feature badges, section content, reduce-motion animation handling, and accessibility expanded/collapsed values are preserved.

Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧹 Chore
  • 📝 Documentation update

Related Issues

  • Not linked

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS 26.5.1
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources
  • Ran formatter locally: swiftformat --config .swiftformat Sources

Additional verification:

  • xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS' CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO — 48 tests passed, 0 failures
  • git diff --check

Notes

  • swiftlint and swiftformat are not installed in this local environment, so those checks were not run.
  • This repository does not currently include a UI test target or SwiftUI view-inspection dependency for automating a row-click regression. The change keeps the interaction localized by making each guide header a full-width SwiftUI Button.

Screenshots / Video

Not included. This is a small interaction-target fix with no intended visual change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant