Skip to content

change: Making _BreakSignal and _ContinueSignal public exceptions#381

Open
jheckey wants to merge 1 commit into
mainfrom
public_control_flow_signals
Open

change: Making _BreakSignal and _ContinueSignal public exceptions#381
jheckey wants to merge 1 commit into
mainfrom
public_control_flow_signals

Conversation

@jheckey

@jheckey jheckey commented Jun 2, 2026

Copy link
Copy Markdown

Issue #, if available:

Description of changes:

Changing _BreakSignal and _ContinueSignal to be public exception classes

Testing done:

Updated tests, reran

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jheckey jheckey changed the title Making _BreakSignal and _ContinueSignal public exceptions change: Making _BreakSignal and _ContinueSignal public exceptions Jun 2, 2026
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e12f376) to head (3429bbe).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #381   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         4882      4884    +2     
  Branches       561       561           
=========================================
+ Hits          4882      4884    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jheckey jheckey force-pushed the public_control_flow_signals branch from 44f1b43 to 3429bbe Compare June 2, 2026 22:04
@jheckey jheckey marked this pull request as ready for review June 2, 2026 22:05
@jheckey jheckey requested a review from a team as a code owner June 2, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant