feat: add Circuit instruction counting#1298
Open
yanziwei wants to merge 1 commit into
Open
Conversation
ffa62cc to
327c8d6
Compare
|
Hello - you are currently over the PR limit for unitaryHACK, so your PRs will be disregarded until you align with the rules. Reach out to hack@unitary.foundation to be reinstated. (PR 2 of 7) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Circuit.count()to count instructions by lowercase operator nameCircuit.count("cnot")for a single instruction type andCircuit.count()for all instruction countsCloses #1235.
Validation
.venv/bin/python -m pytest test/unit_tests/braket/circuits/test_circuit.py -q.venv/bin/python -m ruff check src/braket/circuits/circuit.py.venv/bin/python -m ruff format --check src/braket/circuits/circuit.py test/unit_tests/braket/circuits/test_circuit.pygit diff --checkNote: running
ruff checkon the full existingtest_circuit.pywith the latest local ruff surfaces many pre-existing findings unrelated to this PR, so I scoped lint to the changed source file and used format checking for both touched files.AI use
I used an AI coding assistant to inspect the existing circuit API, implement the small method and tests, and run validation. I reviewed the final diff before submission.