Fix ReduceLROnPlateau compatibility by updating installation instructions#38
Open
Meeex2 wants to merge 1 commit intoamazon-science:mainfrom
Open
Fix ReduceLROnPlateau compatibility by updating installation instructions#38Meeex2 wants to merge 1 commit intoamazon-science:mainfrom
Meeex2 wants to merge 1 commit intoamazon-science:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
ReduceLROnPlateau compatibility by updating installation instructions
Description of changes:
This PR updates the installation instructions in the README to ensure compatibility with the current implementation of
ReduceLROnPlateauused intabsyn/tabsyn/vae/main.py.Newer versions of PyTorch have removed the
verboseargument fromtorch.optim.lr_scheduler.ReduceLROnPlateau, which causes an error when running the training code.Solution
Instead of installing the latest version of PyTorch via:
This PR updates the README to recommend installing specific compatible versions:
This ensures the code runs without errors until the usage of
verboseis updated in the codebase.Testing
Tested locally using the proposed versions and confirmed that the issue is resolved.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.